Skip to content

Fix popover arrow position when aligned to end without explicit side#3774

Merged
Simrayz merged 1 commit intomasterfrom
fix/3770-popover-arrow-is-not-positioned-correctly
Feb 11, 2026
Merged

Fix popover arrow position when aligned to end without explicit side#3774
Simrayz merged 1 commit intomasterfrom
fix/3770-popover-arrow-is-not-positioned-correctly

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Feb 10, 2026 •
edited
Loading

Scope and purpose

Fixes #3770

This PR fixes the placement of the popover arrow when alignment is set to "end".

image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz requested a review from a team February 10, 2026 14:52
@Simrayz Simrayz self-assigned this Feb 10, 2026
@Simrayz Simrayz marked this pull request as ready for review February 10, 2026 14:52
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2026

Test results

    21 files      21 suites   24m 24s ⏱️
 2 851 tests  2 851 ✅ 0 💤 0 ❌
15 954 runs  15 954 ✅ 0 💤 0 ❌

Results for commit fdb291e.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.21%. Comparing base (7181642) to head (fdb291e).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3774   +/-   ##
=======================================
  Coverage   63.21%   63.21%           
=======================================
  Files         617      617           
  Lines       45646    45646           
  Branches       43       43           
=======================================
  Hits        28856    28856           
  Misses      16780    16780           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

johannaengland
johannaengland approved these changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast!

@Simrayz Simrayz merged commit b7550bf into master Feb 11, 2026
20 checks passed
@Simrayz Simrayz deleted the fix/3770-popover-arrow-is-not-positioned-correctly branch February 11, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johannaengland johannaengland johannaengland approved these changes

Assignees

@Simrayz Simrayz

Labels

frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arrow of popover in threshold page is misaligned

2 participants

@Simrayz @johannaengland