Skip to content

Fix SeedDB Patch and Cable pages so the search filters all visible columns#3761

Merged
Simrayz merged 1 commit intomasterfrom
fix/3760-filtering-on-seeddb-patch-and-cables-pages
Feb 6, 2026
Merged

Fix SeedDB Patch and Cable pages so the search filters all visible columns#3761
Simrayz merged 1 commit intomasterfrom
fix/3760-filtering-on-seeddb-patch-and-cables-pages

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Feb 5, 2026 •
edited
Loading

Scope and purpose

Fixes #3760

This PR fixes the search filter on the SeedDB Patch and Cable pages so that all visible columns are filterable.

Screenshots

Screen.Recording.2026-02-05.at.16.54.59.mov

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz requested a review from a team February 5, 2026 15:59
@Simrayz Simrayz self-assigned this Feb 5, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026 •
edited
Loading

Test results

    27 files      27 suites   45m 18s ⏱️
 2 804 tests  2 804 ✅ 0 💤 0 ❌
20 822 runs  20 822 ✅ 0 💤 0 ❌

Results for commit 20a8b28.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.14%. Comparing base (40e206f) to head (20a8b28).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3761   +/-   ##
=======================================
  Coverage   63.14%   63.14%           
=======================================
  Files         614      614           
  Lines       45502    45502           
  Branches       43       43           
=======================================
  Hits        28734    28734           
  Misses      16758    16758           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lunkwill42
lunkwill42 approved these changes Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Simrayz Simrayz merged commit e47c456 into master Feb 6, 2026
28 of 29 checks passed
@Simrayz Simrayz deleted the fix/3760-filtering-on-seeddb-patch-and-cables-pages branch February 6, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

Assignees

@Simrayz Simrayz

Labels

frontend seeddb

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Filtering on SeedDB Patch and Cable pages only filters on jack name

2 participants

@Simrayz @lunkwill42