Fix SeedDB Patch and Cable pages so the search filters all visible columns

Simrayz · Simrayz · commit 20a8b289067f · 2026-02-05T16:58:15.000+01:00
diff --git a/changelog.d/3760.fixed.md b/changelog.d/3760.fixed.md
@@ -0,0 +1 @@
+Filtering on SeedDB Patch and Cable pages now searches all visible columns instead of only the jack field
diff --git a/python/nav/web/api/v1/views.py b/python/nav/web/api/v1/views.py
@@ -577,7 +577,7 @@ class PatchViewSet(NAVAPIMixin, viewsets.ReadOnlyModelViewSet):
 
     Search
     ------
-    Searches in the cables *jack*-field
+    Searches in *jack*, *room*, *sysname*, *ifname*, *ifalias*
 
     Filters
     -------
@@ -597,15 +597,21 @@ class PatchViewSet(NAVAPIMixin, viewsets.ReadOnlyModelViewSet):
     ).all()
     serializer_class = serializers.PatchSerializer
     filterset_fields = ('cabling', 'cabling__room', 'interface', 'interface__netbox')
-    search_fields = ('cabling__jack',)
+    search_fields = (
+        'cabling__jack',
+        'cabling__room__id',
+        'interface__netbox__sysname',
+        'interface__ifname',
+        'interface__ifalias',
+    )
 
 
 class CablingViewSet(NAVAPIMixin, viewsets.ReadOnlyModelViewSet):
     """Lists all cables.
 
     Search
     ------
-    Searches in *jack*, *target_room*, *building*
+    Searches in *jack*, *target_room*, *building*, *description*, *category*, *room*
 
     Filters
     -------
@@ -620,7 +626,14 @@ class CablingViewSet(NAVAPIMixin, viewsets.ReadOnlyModelViewSet):
 
     serializer_class = serializers.CablingSerializer
     filterset_fields = ('room', 'jack', 'building', 'target_room', 'category')
-    search_fields = ('jack', 'target_room', 'building')
+    search_fields = (
+        'jack',
+        'target_room',
+        'building',
+        'description',
+        'category',
+        'room__id',
+    )
 
     def get_queryset(self):
         queryset = cabling.Cabling.objects.all()

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Filtering on SeedDB Patch and Cable pages now searches all visible columns instead of only the jack field`