Skip to content

Change path to default_account in settings#3651

Merged
johannaengland merged 2 commits into5.15.xfrom
bugfix/api-root-unauthenticated
Nov 13, 2025
Merged

Change path to default_account in settings#3651
johannaengland merged 2 commits into5.15.xfrom
bugfix/api-root-unauthenticated

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

Scope and purpose

Fixes #3650. This was forgotten in #3599.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2025

Test results

    27 files      27 suites   45m 16s ⏱️
 2 666 tests  2 666 ✅ 0 💤 0 ❌
19 718 runs  19 718 ✅ 0 💤 0 ❌

Results for commit 277c84f.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.81%. Comparing base (3729d1a) to head (277c84f).
⚠️ Report is 20 commits behind head on 5.15.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           5.15.x    #3651      +/-   ##
==========================================
- Coverage   62.82%   62.81%   -0.02%     
==========================================
  Files         611      611              
  Lines       45125    45125              
  Branches       43       43              
==========================================
- Hits        28349    28344       -5     
- Misses      16766    16771       +5     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To-the-point fix, but we don't want to add commented out test code...

@johannaengland johannaengland requested review from a team and lunkwill42 November 13, 2025 10:29
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When accessing API root as unauthenticated user it leads to an error
See #3650
This was moved in #3599, but this instance was forgotten to be changed
Which lead an error when accessing the API when unauthenticated
@johannaengland johannaengland force-pushed the bugfix/api-root-unauthenticated branch from 0ea74f8 to 277c84f Compare November 13, 2025 11:44
@sonarqubecloud
Copy link
Copy Markdown

@johannaengland johannaengland merged commit 2f46c7e into 5.15.x Nov 13, 2025
19 checks passed
@lunkwill42 lunkwill42 deleted the bugfix/api-root-unauthenticated branch February 27, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Accessing the API root as unauthenticated user raises internal server error

2 participants