Stop accessing/altering request.account directly#3599
Merged
Conversation
a36edd7 to
b4c9715
Compare
Test results 27 files 27 suites 45m 23s ⏱️ Results for commit bfbb994. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3599 +/- ##
==========================================
- Coverage 62.51% 62.50% -0.01%
==========================================
Files 611 611
Lines 45020 45093 +73
Branches 43 43
==========================================
+ Hits 28142 28186 +44
- Misses 16868 16897 +29
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 17, 2025
Switch to Account.is_anonymous instead of Account.is_default_account() in Python and templates
#3606
Merged
b4c9715 to
c2b89b9
Compare
lunkwill42
approved these changes
Oct 17, 2025
Member
lunkwill42
left a comment
There was a problem hiding this comment.
LGTM. Some warts, but some of them will be fixed in subsequent PRs working with the auth system going forward...
lunkwill42
requested changes
Oct 17, 2025
Member
lunkwill42
left a comment
There was a problem hiding this comment.
I see now that tests are failing?
c2b89b9 to
6517661
Compare
10 tasks
3e0d584 to
8de6484
Compare
bfbb994 to
8bc85fd
Compare
|
johannaengland
added a commit
that referenced
this pull request
Nov 12, 2025
This was moved in #3599, but this instance was forgotten to be changed Which lead an error when accessing the API when unauthenticated
johannaengland
added a commit
that referenced
this pull request
Nov 12, 2025
This was moved in #3599, but this instance was forgotten to be changed Which lead an error when accessing the API when unauthenticated
6 tasks
johannaengland
added a commit
that referenced
this pull request
Nov 13, 2025
This was moved in #3599, but this instance was forgotten to be changed Which lead an error when accessing the API when unauthenticated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3598. Nobody should notice this change, tests should be green, sudo should work.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
[ ] Added a changelog fragment for towncrier[ ] Added/amended tests for new/changed code[ ] Added/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.[ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done[ ] If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)[ ] If this results in changes in the UI: Added screenshots of the before and after[ ] If this adds a new Python source code file: Added the boilerplate header to that file