Shared dashboards: Export and import of shared dashboards#3559
Merged
Simrayz merged 3 commits intofeat/support-loading-shared-dashboardsfrom Oct 2, 2025
Merged
Conversation
Test results 27 files 27 suites 45m 12s ⏱️ Results for commit c2ad147. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/support-loading-shared-dashboards #3559 +/- ##
=======================================================================
Coverage 62.20% 62.20%
=======================================================================
Files 611 611
Lines 44925 44925
Branches 43 43
=======================================================================
Hits 27946 27946
Misses 16969 16969
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
reviewed
Sep 25, 2025
hmpf
reviewed
Sep 25, 2025
Contributor
hmpf
left a comment
There was a problem hiding this comment.
I'll do a manual test of the whole shebang.
72e875f to
d3ee6c1
Compare
786c8d9 to
51b48a4
Compare
hmpf
approved these changes
Sep 25, 2025
Contributor
Author
Yeah, I kinda agree. It makes sense as a separate action, and would be consistent between owned and shared dashboards. Export is not really a "setting" anyways. |
0c679f8 to
bb94025
Compare
51b48a4 to
af45959
Compare
bb94025 to
f3078e4
Compare
af45959 to
a56d931
Compare
Contributor
Author
|
Added a follow-up task (#3564) to add consistency to the export function |
5340d39 to
edd62b1
Compare
a56d931 to
c2ad147
Compare
johannaengland
approved these changes
Sep 30, 2025
| <i class="fa fa-download" title="Export dashboard"></i> | ||
| </a> | ||
| <div id="export-action-tooltip" role="tooltip"> | ||
| Download this dashboards definition into a file that can later be imported by pressing the + next to the tab list |
Contributor
There was a problem hiding this comment.
Suggested change
| Download this dashboards definition into a file that can later be imported by pressing the + next to the tab list | |
| Download this dashboard's definition into a file that can later be imported by pressing the + next to the tab list |
9 tasks
lunkwill42
approved these changes
Oct 2, 2025
c2ad147 to
3271252
Compare
771f0a7
into
feat/support-loading-shared-dashboards
13 of 14 checks passed
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Resolves #3558, part of #2344.
Dependent on #3553.
This PR adds support for exporting shared dashboards, and an export action to the widget actions. I also added tests for the export view, as there were none.
In addition, I fixed a weird bug where a non-admin can't open the import modal due to this fun typo:
/îndex/dashboard/importmodalinstead of/index/dashboard/importmodal.Screenshots
Export dashboard action on shared dashboards
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.