Shared dashboards: Add dashboard search form#3557
Shared dashboards: Add dashboard search form#3557Simrayz merged 4 commits intofeat/support-loading-shared-dashboardsfrom
Conversation
Test results 27 files 27 suites 45m 18s ⏱️ Results for commit 0b6a32d. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/support-loading-shared-dashboards #3557 +/- ##
==========================================================================
+ Coverage 62.20% 62.21% +0.01%
==========================================================================
Files 611 611
Lines 44925 44939 +14
Branches 43 43
==========================================================================
+ Hits 27946 27960 +14
Misses 16969 16969
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
left a comment
There was a problem hiding this comment.
Nothing serious spotted, will test manually.
72e875f to
d3ee6c1
Compare
06e6e4d to
13a456e
Compare
hmpf
left a comment
There was a problem hiding this comment.
Passes manual test with flying colors but I got a bit confused about how to subscribe/knowing if the dashboard was subscribed to.
lunkwill42
left a comment
There was a problem hiding this comment.
I only have time to add one usability thought before I have to run:
Clicking the search button opens a modal, but I need to manually click the search element to enter search text. The search text field should be automatically focused when the dialog appears.
13a456e to
1ccf3c1
Compare
Added autofocus to the search input, and adjusted subscribed tag and view button slightly. 
|
0c679f8 to
bb94025
Compare
1ccf3c1 to
ddaea53
Compare
bb94025 to
f3078e4
Compare
7514947 to
96ea344
Compare
5340d39 to
edd62b1
Compare
96ea344 to
0b6a32d
Compare
johannaengland
left a comment
There was a problem hiding this comment.
I agree that having both way of getting to the search is overkill and I prefer having the search within the "Add dashboard" popover
lunkwill42
left a comment
There was a problem hiding this comment.
I think this will do, but agree with most of what @johannaengland said as well :)
0b6a32d to
0e09189
Compare
2dfd09c
into
feat/support-loading-shared-dashboards
|
Scope and purpose
Resolves #3556, part of #2344.
Dependent on PR #3553.
No-news as #3551 contains the news fragment.
This PR adds search functionality to the dashboard navigation. A user can search for shared dashboards by dashboard name, account name or account login. Dashboards belonging to the current account are excluded, and the search results show whether the user is currently subscribed.
I added two methods of triggering the search modal: From within the "Add dashboard" popover, and with a separate search button. Having both might be overkill, but I either could be a good solution.
This pull request
nameto thenon_admin_accountfixture, necessary for the tests to work.How to test
You'll need two different users, so if have admin and you can make a new test user that's the easiest.
Screenshots
Dashboard search results
Open dashboard search
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.