Use help text toggle instead of tooltip in alert action select#3466
Use help text toggle instead of tooltip in alert action select#3466lunkwill42 merged 2 commits intomasterfrom
Conversation
f47b966 to
a989f7d
Compare
Test results 12 files 12 suites 11m 50s ⏱️ Results for commit 7d7572a. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3466 +/- ##
==========================================
+ Coverage 61.02% 61.04% +0.02%
==========================================
Files 610 610
Lines 44707 44708 +1
Branches 43 43
==========================================
+ Hits 27282 27294 +12
+ Misses 17415 17404 -11
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Definite improvement! Much easier to update the text later.
hmpf
left a comment
There was a problem hiding this comment.
I like this, we just have to agree on colors and curves.
johannaengland
left a comment
There was a problem hiding this comment.
I'm not sure if this is related to this PR, or if this is another issue, but when I get close to the dropdown, but not on it yet, my cursor makes it look like it's clickable, but nothing happens when I click there
And I don't know if this is just me, but the help text looks differently than in the screenshots:
|
|
@johannaengland When using a label with |
Of course that was the problem, all there now! 🙄 thanks for the tip! |
johannaengland
left a comment
There was a problem hiding this comment.
I really like this. I think it looks clean and is very functional.
I'm just waiting for our meeting about style before giving my explicit approval
Scope and purpose
Fixes #3463 by replacing the foundation tooltip with a toggleable help text section.
This change is both part of the meta issue #2972 and a general UX improvement.
Screenshots
Before
See #3463 for before pictures and a video of the flickering behaviour of the tooltip.
After (Help text hidden)
After (Help text visible)
Contributor Checklist
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.(https://nav.readthedocs.io/en/latest/hacking/hacking.html#python-boilerplate-headers) to that file