Implement ipdevinfo UI for ipdevpoll job refreshing#3385
Implement ipdevinfo UI for ipdevpoll job refreshing#3385johannaengland merged 4 commits intoUninett:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
- Coverage 60.89% 60.83% -0.07%
==========================================
Files 608 608
Lines 44237 44273 +36
Branches 48 48
==========================================
- Hits 26940 26934 -6
- Misses 17285 17327 +42
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This can now potentially be based on #3386 |
6f37b63 to
6a69618
Compare
81834da to
be08c40
Compare
|
I did some more digging and found the problem that I'm surprised didn't pop up before: After having triggered a job that does not finish After deleting the cookie when running it for the first time both the case of ipdevpoll not running and the job running longer than expected are working as expected. |
lunkwill42
left a comment
There was a problem hiding this comment.
The bits added since our last join session look ok - I only have naming issues. But, I'm also commenting on older changes made while I was on vacation :)
0db4da4 to
f7998c0
Compare
016f238 to
1dcdc6d
Compare
bee6b7a to
a89e324
Compare
lunkwill42
left a comment
There was a problem hiding this comment.
SonarQube is not happy. Is there something amiss with the pre-commit config?
We do not check for line-too-long violations (E501) while linting, but formatting should take care of this automatically, but it does not. I will look into this, but will fix this manually first. |
lunkwill42
left a comment
There was a problem hiding this comment.
Still pretty happy with the codebase (it was a team effort, after all). Only nitpick is SonarQube's: Docstrings :)
podliashanyk
left a comment
There was a problem hiding this comment.
Looks good to me! I like the solution with query parameter instead of state vis session.
I would suggest that @hmpf also takes a look at this one since she is the only one who didn't participate in mob-programming sessions.
560bf9d to
5964814
Compare
|
The back-end feature has been merged to master. I've therefore taken the liberty to squash fixup commits and rebase this entire PR on the latest master. |
hmpf
left a comment
There was a problem hiding this comment.
Code looks fine, seems to work.
We might get away with fewer template files once we're on Django 6.0, see:
https://docs.djangoproject.com/en/dev/ref/templates/language/#template-partials
Co-authored-by: Ilona Podliashanyk <ilona.podliashanyk@sikt.no> Co-authored-by: Simon Oliver Tveit <simon.tveit@sikt.no> Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no> Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
Co-authored-by: Ilona Podliashanyk <ilona.podliashanyk@sikt.no> Co-authored-by: Simon Oliver Tveit <simon.tveit@sikt.no> Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no> Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
Co-authored-by: Ilona Podliashanyk <ilona.podliashanyk@sikt.no> Co-authored-by: Simon Oliver Tveit <simon.tveit@sikt.no> Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no> Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
Co-authored-by: Ilona Podliashanyk <ilona.podliashanyk@sikt.no> Co-authored-by: Simon Oliver Tveit <simon.tveit@sikt.no> Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no> Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
5964814 to
72fac41
Compare
|
This PR represents a mob effort of working out an implementation for #3350. Since it reached maturity, its history has been rebased and edited to present cleanly.
All involved in the mob effort are happy with it, we're just waiting for @hmpf to review it, since she wasn't present at the mob meetings.
Follow up issue #3448.