Skip to content

Add HTMX 2.0.4 and Django-HTMX to NAV#3386

Merged
lunkwill42 merged 3 commits intomasterfrom
feature/htmx
Jul 25, 2025
Merged

Add HTMX 2.0.4 and Django-HTMX to NAV#3386
lunkwill42 merged 3 commits intomasterfrom
feature/htmx

Conversation

@lunkwill42
Copy link
Copy Markdown
Member

This can be used as a base for upcoming PRs that want to build HTMX features for NAV before HTMX is merged to master.

This replaces parts of #2883 and is part of #2639

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 12, 2025

Test results

   12 files     12 suites   12m 1s ⏱️
2 194 tests 2 194 ✅ 0 💤 0 ❌
6 057 runs  6 057 ✅ 0 💤 0 ❌

Results for commit 96c81ee.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would like it to specify which version of HTMX is vendored. Let's rename file to htmx-2.0.4.min.js to help with it.

@hmpf hmpf self-requested a review June 13, 2025 07:59
Copy link
Copy Markdown
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @podliashanyk

@lunkwill42 lunkwill42 requested review from hmpf and podliashanyk June 13, 2025 09:27
@lunkwill42
Copy link
Copy Markdown
Member Author

Looks good, but I would like it to specify which version of HTMX is vendored. Let's rename file to htmx-2.0.4.min.js to help with it.

Agreed, fixed :)

@sonarqubecloud
Copy link
Copy Markdown

@lunkwill42
Copy link
Copy Markdown
Member Author

I suggest leaving this in draft mode until we have 1 complete feature based on this PR. At that point, this can be merged, and that feature can then be merged.

@lunkwill42 lunkwill42 marked this pull request as ready for review July 25, 2025 11:46
@lunkwill42
Copy link
Copy Markdown
Member Author

Several features based on this are now pending, and some of them are dependent on multiple, otherwise unrelated, PRs, so it's time to merge this.

@lunkwill42 lunkwill42 merged commit 991b012 into master Jul 25, 2025
15 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (91324db) to head (96c81ee).
Report is 34 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #3386   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lunkwill42 lunkwill42 deleted the feature/htmx branch July 25, 2025 11:47
@lunkwill42 lunkwill42 restored the feature/htmx branch July 25, 2025 12:44
@lunkwill42 lunkwill42 deleted the feature/htmx branch July 25, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants