Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3266 +/- ##
==========================================
+ Coverage 61.61% 62.05% +0.44%
==========================================
Files 611 611
Lines 44813 44854 +41
Branches 43 43
==========================================
+ Hits 27610 27835 +225
+ Misses 17193 17009 -184
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I guess this needs a rebase, as #2850 was modified and merged.. |
|
Python 3.12 needs an lxml that is newer than or equal to 5.0. |
|
Warnings: |
|
Warnings during testing: |
|
bb8a8f5 to
f6455cb
Compare
|
Rebased on latest master |
|
We should really add 3.13 to this also :) |
|
Newest problem:
|
Nah, we need to be up and running on Django 5.2 first. 4.2 only supports up to and including 3.12. |
This one is a bit hard to locate 😏 |
|
Here's a solution to the USE_L10N-flag disappearing: https://docs.djangoproject.com/en/5.2/topics/i18n/formatting/#creating-custom-format-files |
fef2948 to
71e6f29
Compare
f249aa2 to
4af2196
Compare
Astroid is a requirement of pylint which we no longer use. Lxml is a dependency of napalm and napalm should control its version.
This was the unset default of Django's until but not including Django 5.0. Nav depends on it being "False" and changing it to "True" would be a major undertaking.
4654ae7 to
f1c8ef9
Compare
f1c8ef9 to
0d10e82
Compare
johannaengland
left a comment
There was a problem hiding this comment.
Just one nitpick about the argument to naventity
It's this high because while 15 (the old one + the new 5 sec timeout to naventity, round up) is high enough when testing locally, GitHub CI needed 20.
eafe386 to
354396d
Compare
|



Depends on #2850
If using devcontainers, set
MAIN_PYTHON_VERSIONindevcontainer/docker-compose.ymlto 3.12.This pull request
Removed test requirements:
Changed:
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
[ ] Added/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.[ ] If this results in changes in the UI: Added screenshots of the before and after[ ] If this adds a new Python source code file: Added the boilerplate header to that file