Skip to content

Test on python 3.11, Django 4.2#2850

Merged
lunkwill42 merged 7 commits intoUninett:masterfrom
hmpf:test/python3.11
Feb 20, 2025
Merged

Test on python 3.11, Django 4.2#2850
lunkwill42 merged 7 commits intoUninett:masterfrom
hmpf:test/python3.11

Conversation

@hmpf
Copy link
Copy Markdown
Contributor

@hmpf hmpf commented Mar 1, 2024 •
edited by lunkwill42
Loading

@hmpf hmpf changed the title Test on python 3.11,Django 4.2, 5.0 Test on python 3.11, Django 4.2, 5.0 Mar 1, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.59%. Comparing base (35b0f71) to head (2d802c7).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2850   +/-   ##
=======================================
  Coverage   60.58%   60.59%           
=======================================
  Files         606      606           
  Lines       43733    43733           
  Branches       48       48           
=======================================
+ Hits        26494    26498    +4     
+ Misses      17227    17223    -4     
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2024 •
edited
Loading

Test results

       19 files         19 suites   13m 57s ⏱️
  3 322 tests   3 316 ✔️ 0 💤 0 ❌   6 🔥
11 877 runs  11 865 ✔️ 0 💤 0 ❌ 12 🔥

For more details on these errors, see this check.

Results for commit 54a3330.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the test/python3.11 branch 2 times, most recently from f98f06f to 3d61442 Compare March 1, 2024 09:14
@hmpf
Copy link
Copy Markdown
Contributor Author

hmpf commented Mar 1, 2024 •
edited
Loading

Django 4.2 and later fails on the integration tests and functional tests because form-rendering is changed and the foundation 5 theme we use for django-crispy-forms do not support the new way.

django.template.exceptions.TemplateDoesNotExist: foundation-5/layout/div.html

We use Foundation 5. crispy-forms-foundation 0.8 dropped support for Foundation 5 when released on May 20, 2020.

Needed by current versions of crispy-forms-foundation:

Upgrading crispy-forms is tracked by #2794 so until that is solved we are stuck with maximum versions of Django 3.2 and Python 3.10.

@hmpf hmpf added the blocked label Mar 1, 2024
@hmpf hmpf mentioned this pull request Mar 1, 2024
Closed
@hmpf hmpf force-pushed the test/python3.11 branch 3 times, most recently from 3412328 to 1995869 Compare March 7, 2024 09:05
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf force-pushed the test/python3.11 branch from 1995869 to 54a3330 Compare March 7, 2024 09:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lunkwill42 lunkwill42 mentioned this pull request Dec 12, 2024
Closed
10 tasks
@lunkwill42
Copy link
Copy Markdown
Member

lunkwill42 commented Dec 12, 2024

This was recently rebased on the latest master and updated, as crispy-forms is now finally removed from NAV.

This was referenced Jan 27, 2025
Merged
Closed
Merged
@lunkwill42 @hmpf
Set up test envs for Python 3.11
154c28f 
We should've been testing for Python 3.11 for a long time now, it's
time to start!
@hmpf hmpf force-pushed the test/python3.11 branch 2 times, most recently from 24384fa to 12bf3dd Compare January 28, 2025 08:41
@hmpf hmpf changed the title Test on python 3.11, Django 4.2, 5.0 Test on python 3.11, Django 4.2 Jan 28, 2025
@hmpf hmpf marked this pull request as ready for review January 28, 2025 09:40
This was referenced Jan 28, 2025
Merged
Closed
@hmpf hmpf added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Feb 18, 2025
@hmpf hmpf requested review from johannaengland, lunkwill42 and stveit and removed request for johannaengland February 18, 2025 13:35
lunkwill42
lunkwill42 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lunkwill42 lunkwill42 removed the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Feb 20, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lunkwill42 lunkwill42 merged commit 4f16e3a into Uninett:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@johannaengland johannaengland johannaengland approved these changes

@stveit stveit Awaiting requested review from stveit

Assignees

@lunkwill42 lunkwill42

@hmpf hmpf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmpf @lunkwill42 @johannaengland