Fix LegacyGenericForeignKey#3263
Merged
lunkwill42 merged 4 commits intoUninett:masterfrom Feb 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3263 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 606 606
Lines 43733 43736 +3
Branches 48 48
=======================================
+ Hits 26494 26499 +5
+ Misses 17227 17225 -2
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 27, 2025
We should've been testing for Python 3.11 for a long time now, it's time to start!
2de7923 to
07a4a14
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2850
This only adapts modern methods for caching. It might be wise to rewrite lgfk in such a way as to make it more like the modern GenericForeignKey but if this works, that's really good enough.