Add support for positioning popover on multiple sides#3550
Merged
Conversation
|
9 tasks
Test results 27 files 27 suites 44m 29s ⏱️ Results for commit bedf67f. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3550 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 611 611
Lines 44865 44865
Branches 43 43
=======================================
Hits 27861 27861
Misses 16994 16994
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannaengland
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
Follow up to #3458, and necessary to position popovers in #3531.
data-sideattribute, as described in the styleguide.data-sideattribute, and the example was updated to use adata-side="right" data-align="start"configuration.data-align="center"was removed, as it is not likely to be used, and to simplify the code for multiple sides._popover.scsswas refactored to be more readable and reduce unnecessary nesting. It should be easier to follow the logic now.I'm a bit uncertain if putting the
data-*attributes on the.popovercontainer was the best idea (the styles become a bit convoluted). We might want to consider movingdata-side,data-alignandwith-arrowto the.popover-contentcontainer instead. Alternatively, combine the attributes intodata-position="bottom-start"etc. However, this requires refactoring a lot of files, and would cause conflicts with #3531.Screenshots
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.