POC: Replace foundation dropdowns with popover#3458
Merged
Conversation
4d44222 to
2c294c6
Compare
|
Test results 12 files 12 suites 12m 12s ⏱️ Results for commit 2c294c6. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3458 +/- ##
==========================================
+ Coverage 60.99% 61.02% +0.02%
==========================================
Files 610 610
Lines 44589 44707 +118
Branches 43 43
==========================================
+ Hits 27199 27282 +83
- Misses 17380 17415 +35
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
approved these changes
Aug 29, 2025
Contributor
hmpf
left a comment
There was a problem hiding this comment.
Looks fine, possible follow up: use a component template for these, add to style guide.
lunkwill42
approved these changes
Aug 29, 2025
Member
lunkwill42
left a comment
There was a problem hiding this comment.
LGTM. As @hmpf said, make followup issues :-)
This was referenced Sep 1, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Part of meta #2972.
Replaces instances of
foundation('dropdown', ...)and creates styles and javascript to create standalone popover components. I used the namepopoverto differentiate it from existing dropdowns, and because it is the more general name for "place something relative to this element".Replaces the following lines of foundation js:
nav/python/nav/web/static/js/src/status2/views.js
Line 171 in 813b12a
nav/python/nav/web/static/js/src/threshold.js
Line 56 in 813b12a
Screenshots
Before
"Dropdown" is outside the view.
"No way" button doesn't work
After
Icon has cursor pointer, and aligned correctly
"No way" button works
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.