Skip to content

Replace Portadmin Feedback Modal#3540

Merged
Simrayz merged 1 commit intomasterfrom
chore/replace-portadmin-modal
Sep 23, 2025
Merged

Replace Portadmin Feedback Modal#3540
Simrayz merged 1 commit intomasterfrom
chore/replace-portadmin-modal

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Sep 12, 2025

Scope and purpose

Dependent on #3538 (closing behaviour), part of #2972.

This PR replaces the foundation modal with an HTMX implementation. It also slightly refactors the code to use promises and async code, as the JS handlers need to wait for the modal to load before displaying feedback.

I added screen recordings since Portadmin is difficult to test, and the process takes a long time (over 1 minute to save changes).

This pull request

  • adds/changes/removes a dependency
  • changes the database
  • changes the API

Screen Recordings

Before

portadmin-foundation-feedback.mov

After

portadmin-htmx-feedback.mov

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Sep 12, 2025
@Simrayz Simrayz force-pushed the chore/replace-portadmin-modal branch 2 times, most recently from a01e7c9 to d378bbf Compare September 12, 2025 12:38
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2025 •
edited
Loading

Test results

    27 files      27 suites   44m 25s ⏱️
 2 516 tests  2 516 ✅ 0 💤 0 ❌
18 518 runs  18 518 ✅ 0 💤 0 ❌

Results for commit 1a7bfd4.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.10%. Comparing base (0272261) to head (dfe284d).
⚠️ Report is 337 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3540   +/-   ##
=======================================
  Coverage   62.09%   62.10%           
=======================================
  Files         611      611           
  Lines       44865    44868    +3     
  Branches       43       43           
=======================================
+ Hits        27861    27864    +3     
  Misses      16994    16994           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz deleted the branch master September 15, 2025 07:13
@Simrayz Simrayz closed this Sep 15, 2025
@Simrayz Simrayz reopened this Sep 15, 2025
@Simrayz Simrayz changed the base branch from feat/support-manual-close-in-modal to master September 15, 2025 07:19
@Simrayz Simrayz mentioned this pull request Sep 15, 2025
Closed
@Simrayz Simrayz force-pushed the chore/replace-portadmin-modal branch from d378bbf to df5956e Compare September 15, 2025 09:08
@Simrayz Simrayz requested a review from a team September 15, 2025 09:08
@Simrayz Simrayz marked this pull request as ready for review September 15, 2025 09:08
@Simrayz Simrayz mentioned this pull request Sep 15, 2025
Merged
9 tasks
johannaengland
johannaengland approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nitpick (but I don't think it matters too much) is that the modal is now also changing in width between the first and the second message. Can we avoid that?

@Simrayz Simrayz force-pushed the chore/replace-portadmin-modal branch from df5956e to 1a7bfd4 Compare September 17, 2025 20:58
@Simrayz Simrayz force-pushed the chore/replace-portadmin-modal branch from 1a7bfd4 to dfe284d Compare September 23, 2025 07:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 23, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Simrayz Simrayz merged commit 4689f75 into master Sep 23, 2025
16 checks passed
@Simrayz Simrayz deleted the chore/replace-portadmin-modal branch September 23, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johannaengland johannaengland johannaengland approved these changes

Assignees

@Simrayz Simrayz

Labels

cleanup htmx javascript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Simrayz @johannaengland