Merged
Conversation
|
Test results 12 files 12 suites 13m 1s ⏱️ Results for commit 0242ab8. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3538 +/- ##
=======================================
Coverage 62.02% 62.02%
=======================================
Files 611 611
Lines 44850 44850
Branches 43 43
=======================================
Hits 27818 27818
Misses 17022 17022
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
Resolves #3537.
This PR adds closing behaviour controls to the
render_modalutility. This is necessary to support "persistent modal" patterns, specifically the feedback modal in the Portadmin tool.I have added two new options when rendering modals:
close_on_outside_click(default: True): Whether to close the modal when clicking the background (modal overlay).show_close_button(default: True): Whether to show thexbutton in the top right corner.This pull request
render_modalHow to test
I tested the new options by modifying the Image Upload Help modal. However, this PR does not commit any changes to existing modals as it is purely a "utility update".
To manually test the changes yourself, find a random modal and set the two new options to
False.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.