refactor(ui5-toast): replace show method with open property#8855
Merged
refactor(ui5-toast): replace show method with open property#8855
show method with open property#8855Conversation
Users now can open `ui5-toast` using the open property. A new event `after-close` is introduced. It may be used to sync app state with the `open` state of the `ui5-toast`. BREAKING CHANGE: removed `show()`, set `open` property to true instead. Related to: #8461
hristop
approved these changes
Apr 26, 2024
nnaydenow
reviewed
Apr 26, 2024
| /** | ||
| * Fired after the component is auto closed. | ||
| * @public | ||
| */ |
Contributor
There was a problem hiding this comment.
add @since 2.0.0 tag. same for open property
nnaydenow
pushed a commit
that referenced
this pull request
Apr 29, 2024
Users now can open `ui5-toast` using the `open` property. A new event `after-close` is introduced. It may be used to sync app state with the `open` state of the `ui5-toast`. BREAKING CHANGE: The Toast#show method has been replaced by `open` property. If you previously used `toast.show()` to show the toast, you must now se `toast.open=true`. Related to: #8461
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users now can open
ui5-toastusing theopenproperty. A new eventafter-closeis introduced.It may be used to sync app state with the
openstate of theui5-toast.BREAKING CHANGE: The Toast#show method has been replaced by
openproperty. If you previously usedtoast.show()to show the toast, you must now setoast.open=true.Related to: #8461