feat(ui5-date-picker): Replace openPicker method with open property#8749
Merged
feat(ui5-date-picker): Replace openPicker method with open property#8749
openPicker method with open property#8749Conversation
BorisDafov
reviewed
Apr 26, 2024
BorisDafov
left a comment
There was a problem hiding this comment.
I approve the PR from UA perspective.
BorisDafov
suggested changes
Apr 26, 2024
unazko
reviewed
Apr 29, 2024
Contributor
unazko
left a comment
There was a problem hiding this comment.
The change behaves as expected.
unazko
approved these changes
Apr 30, 2024
ilhan007
reviewed
Apr 30, 2024
Contributor
|
In BREAKING CHANGES section, you need to provide instructions how each of the previous APIs are replaced now with code examples - you can use all other merged PRs for reference |
tsanislavgatev
previously approved these changes
May 7, 2024
tsanislavgatev
approved these changes
May 8, 2024
ilhan007
approved these changes
May 8, 2024
Closed
LidiyaGeorgieva
pushed a commit
that referenced
this pull request
May 9, 2024
…ty (#8749) Replaced `openPicker` methods with `open` property in `ui5-date-picker`, `ui5-daterange-picker` `ui5-datetime-picker` components. This change promotes a more declarative approach when working with popovers. BREAKING CHANGE: removed `openPicker()`, `closePicker()` and `isOpen()` methods. If you previously used `openPicker()` and `closePicker()`: ```ts const datePicker = document.getElementById("exampleID"); datePicker.openPicker(); datePicker.closePicker(); ``` Now use the `open` property respectively: ```ts const datePicker = document.getElementById("exampleID"); datePicker.open = true; datePicker.open = false; ``` Related to: #8461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
openPickermethods withopenproperty inui5-date-pickerandui5-datetime-pickercomponents. This change promotes a more declarative approach when working with popovers.BREAKING CHANGE: removed
openPicker(),closePicker()andisOpen()methods.Before the ui5-date-picker popover can be opened and closed by calling
openPicker()andclosePicker():Now the popover is opened and closed by updating the
openproperty to true or false respectively:Related to: #8461