Skip to content

[INTERNAL] Removes connectUi5Proxy documentation#722

Merged
d3xter666 merged 8 commits intomainfrom
remove-connect-openui5
Dec 23, 2022
Merged

[INTERNAL] Removes connectUi5Proxy documentation#722
d3xter666 merged 8 commits intomainfrom
remove-connect-openui5

Conversation

@d3xter666
Copy link
Copy Markdown
Member

@d3xter666 d3xter666 commented Dec 20, 2022

This removes the "/proxy" endpoint and the corresponding
"connectUi5Proxy" middleware from the standard ui5-server.
Internally, this middleware made use of the connect-openui5 proxy
implementation (https://github.com/SAP/connect-openui5#proxy).

More sophisticated proxy solutions for ui5-server are already available
in the form of custom middleware extensions from the UI5-community.

The UI5 Team might provide a dedicated custom middleware extension,
with similar functionality, in the future.

Relates to: SAP/ui5-server#550

JIRA: CPOUI5FOUNDATION-598

@d3xter666 d3xter666 requested review from a team and KlattG December 20, 2022 11:46
d3xter666 and others added 2 commits December 20, 2022 15:09
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@d3xter666 d3xter666 requested review from a team and flovogt December 20, 2022 13:09
Copy link
Copy Markdown
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 requested a review from flovogt December 20, 2022 13:16
@flovogt
Copy link
Copy Markdown
Member

flovogt commented Dec 20, 2022

LGTM. Wait for @KlattG review

matz3
matz3 previously requested changes Dec 20, 2022
@d3xter666 d3xter666 requested a review from matz3 December 21, 2022 11:03
@flovogt flovogt requested a review from RandomByte December 21, 2022 11:04
Copy link
Copy Markdown
Contributor

@ecker ecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifying redundant list of standard middlewares. Unfortunately, for the standard tasks it would also be straightforward for the removals, but not so for the (single) addition ...

@d3xter666 d3xter666 requested review from ecker and flovogt December 22, 2022 12:43
Copy link
Copy Markdown
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 merged commit b3d01d7 into main Dec 23, 2022
@d3xter666 d3xter666 deleted the remove-connect-openui5 branch December 23, 2022 10:55
Copy link
Copy Markdown
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions.

d3xter666 added a commit that referenced this pull request Sep 24, 2025
d3xter666 pushed a commit that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants