Fixes #205; make xlwt a dependency for pip installing#206
Merged
UnHumbleBen merged 1 commit intodevfrom Dec 2, 2021
Merged
Conversation
dave-doty
approved these changes
Dec 2, 2021
Member
dave-doty
left a comment
There was a problem hiding this comment.
requires is superseded by install_requires and should not be used anymore.
Well I'm glad to see that I wasn't hallucinating when I put it under "requires". Must have been some outdated documentation that I found online.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved 'xlwt' from
requirestoinstall_requires. Dependencies are supposed to be specified in install_requires. I couldn't find a clear reason whyrequiresis not valid, but I do see in the setuptools keywords page that:Related Issue
#205
Motivation and Context
Currently,
xlwtis not installed when scadnano is installed usingpip.How Has This Been Tested?
Setup: Used new setup.py to make new PyPI test package: https://pypi.org/project/scadnano-test/
pip uninstall xlwtpip install scadnano-testimport xlwtand verified no import error, so xlwt is installed