-
Notifications
You must be signed in to change notification settings - Fork 8
Description
I thought it already was, because of this line in setup.py:
scadnano-python-package/setup.py
Line 55 in d579a40
| requires=['xlwt'], |
However, someone recently installed it from pip, and pip did not install the xlwt dependency. I suspect that perhaps this has been an error all along, but no one has yet tried to call one of the methods writing Excel files.
I tried finding documentation for the requires keyword for the function setuptools.setup, but I can't find any. I think it should be install_requires instead, which we are already using on this line:
scadnano-python-package/setup.py
Lines 56 to 58 in d579a40
| install_requires=[ | |
| 'dataclasses>=0.6;python_version<"3.7"' | |
| ] |
Looking at the source code for setuptools.setup, its type signature is
def setup(**attrs):So I think if you give it a keyword argument it doesn't expect, it simply ignores it, which is why this error was silent for so long.