Conversation
dave-doty
requested changes
Aug 3, 2021
Member
dave-doty
left a comment
There was a problem hiding this comment.
Can you add a commit that has the phrase "fixes #188", so that GitHub will automatically close the issue when this makes it to the main branch? (https://github.com/UC-Davis-molecular-computing/scadnano-python-package/blob/main/CONTRIBUTING.md#pushing-to-the-repository-dev-branch-and-documenting-changes-done-on-all-updates)
Collaborator
Author
done! |
dave-doty
approved these changes
Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying the roll angle to a helix, the function _oxdna_get_helix_vectors was applying the roll angle in the wrong orientation (counterclockwise instead of clockwise). This fix simply flips the direction in which the roll is applied.