feat: added placeholder example#1252
Merged
matthewlipski merged 2 commits intoTypeCellOS:mainfrom Nov 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ezhil56x is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
|
This only works for en locales, if your locale is set to french it won't work, how would you handle that depending on the user locale then? |
Contributor
Author
|
@Blapi Updated, now the user locale can be set |
YousefED
requested changes
Nov 17, 2024
Collaborator
YousefED
left a comment
There was a problem hiding this comment.
nice, some requests commented, then we should be good
| const editor = useCreateBlockNote({ | ||
| dictionary: { | ||
| ...locales[userLocale], | ||
| placeholders: { |
Collaborator
There was a problem hiding this comment.
Besides the default, please also show how you can change the "heading" placeholder
Collaborator
There was a problem hiding this comment.
add a comment to explain code
// We override the `placeholders` in our dictionary
ef431a8 to
776cf32
Compare
Contributor
Author
2024-11-18.10-06-45.mp4@YousefED Updated my PR |
YousefED
approved these changes
Nov 18, 2024
matthewlipski
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1242
/claim #1242
Added an example for placeholder