Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

TT-11145 - Handle connection refused error#679

Merged
buraksekili merged 4 commits intomasterfrom
fix/TT-11145/check-connection-refused
Mar 8, 2024
Merged

TT-11145 - Handle connection refused error#679
buraksekili merged 4 commits intomasterfrom
fix/TT-11145/check-connection-refused

Conversation

@buraksekili
Copy link

@buraksekili buraksekili commented Feb 27, 2024

Description

This PR prevents Tyk Operator from creating redundant APIDefinitions after crash failures. It retries to connect
Gateway if the network error is reproducible.

Related Issue

https://tyktech.atlassian.net/browse/TT-11145

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@buraksekili buraksekili marked this pull request as ready for review March 2, 2024 22:10
@buraksekili buraksekili requested a review from a team as a code owner March 2, 2024 22:10
@buraksekili buraksekili requested review from olamilekan000 and removed request for a team March 2, 2024 22:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

@buraksekili buraksekili merged commit a44f099 into master Mar 8, 2024
@buraksekili buraksekili deleted the fix/TT-11145/check-connection-refused branch March 8, 2024 15:27
buger pushed a commit that referenced this pull request May 22, 2024
* Handle connection refused error

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* only check for connection refused

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* retry for every error that is type of *url.Error

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

---------

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants