This repository was archived by the owner on Oct 11, 2024. It is now read-only.
[TT-8658] Changed optional fields of CRD to pointers#627
Merged
Conversation
andrei-tyk
approved these changes
May 17, 2023
buraksekili
reviewed
May 17, 2023
| } | ||
|
|
||
| key := types.NamespacedName{Name: ctxRef.Name, Namespace: ctxRef.Namespace} | ||
| key := types.NamespacedName{Name: ctxRef.Name, Namespace: namespace} |
There was a problem hiding this comment.
Is providing empty namespace safe for k8s client?
Contributor
Author
There was a problem hiding this comment.
Doesn't it use default namespace when not set?
Contributor
Author
There was a problem hiding this comment.
Set default value to default instead of empty
There was a problem hiding this comment.
If not set, I would not explicitly set to default. I would inherit the namespace from the context.
Collaborator
There was a problem hiding this comment.
Let's fix this in another PR
buraksekili
reviewed
May 17, 2023
buraksekili
reviewed
May 17, 2023
buraksekili
reviewed
May 17, 2023
buraksekili
reviewed
May 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
18 tasks
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Set useKeylessAccess as bool pointer * Convert all bool optional fields to pointers * Convert string types to pointers * Fix pointer references * Fix function used to check equality of target objects * Fix tests * Update deepcopy * Fix linter errors * Converted optional bool fields of security policy to pointers * Convert string optional field of security policy to pointer * Update changelog * Fix lint errors * Fix panic * Fix check * Verify pointer is not nil before accessing it's value * Define error for missing policy id * Validate pointer is not nil before accessing it's value * Avoid using same variable for different pointer variables * Rename variables to camelCase * Use "default" as default value of namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converted
stringandbooloptional fields of APIDefinition and Security Policy to pointers.Here is list of fields that are changed:
API Definition Bool fields
API Definition String fields
Security Policy Bool fields
Security Policy String fields
Related Issue
TT-8658
Resolves #606
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run