Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

[TT-8152] Upgrade go and dependencies version#616

Merged
komalsukhani merged 8 commits intomasterfrom
fix/TT-8152/upgrade_go_version
Apr 24, 2023
Merged

[TT-8152] Upgrade go and dependencies version#616
komalsukhani merged 8 commits intomasterfrom
fix/TT-8152/upgrade_go_version

Conversation

@komalsukhani
Copy link
Contributor

@komalsukhani komalsukhani commented Apr 24, 2023 •
edited
Loading

Description

  • Updated go version from 1.17 to 1.19
  • Fixed Makefile
    From go version 1.18, go get no longer builds or installs packages in module-aware mode. Had to fix the rules used to install controller-gen and kustomize.
  • Updated dependencies version to address alert raised by dependabot.

Related Issue

TT-8152

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@komalsukhani komalsukhani marked this pull request as ready for review April 24, 2023 10:27
@komalsukhani komalsukhani requested a review from a team as a code owner April 24, 2023 10:27
@komalsukhani komalsukhani requested review from andrei-tyk and removed request for a team April 24, 2023 10:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@komalsukhani komalsukhani merged commit f53b45f into master Apr 24, 2023
@komalsukhani komalsukhani deleted the fix/TT-8152/upgrade_go_version branch April 24, 2023 10:44
buger pushed a commit that referenced this pull request May 22, 2024
@komalsukhani
[TT-8152] Upgrade go and dependencies version (#616)
b45f7d1 
* Update go version from 1.17 to 1.19

* Upgrade golang.org/x/net to v0.7.0

* Upgrade golang.org/x/crypto to 0.1.0

* Update go.sum

* Fix makefile

* Fix makefile

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrei-tyk andrei-tyk andrei-tyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@komalsukhani @andrei-tyk