Description

• Refactored secret-cert-controller code
• Fixed panic which was caused by a assignment of value to nil slice. Fixed in commit 032789e

Related Issue

TT-8499

Motivation and Context

Operator was panicking while setting Certificates field of APIDefinition when talking to OSS gateway.

Test Coverage For This Change

• Added integration tests
• Verified the issue is not reproducible.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
• Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
• Make sure you are updating CHANGELOG.md based on your changes.
• My change requires a change to the documentation.
  • If you've changed APIs, describe what needs to be updated in the documentation.
• I have updated the documentation accordingly.
• If you've changed API models, please update CRDs.
  • make manifests
  • make helm
• I have added tests to cover my changes.
• All new and existing tests passed.
• Check your code additions will not fail linting checks:
  • gofmt -s -w .
  • go vet ./...
  • golangci-lint run