This repository was archived by the owner on Oct 11, 2024. It is now read-only.
TT-8234 - fix overriding contextRef while updating policy spec#605
Merged
TT-8234 - fix overriding contextRef while updating policy spec#605
Conversation
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…sions Signed-off-by: Burak Sekili <buraksekili@gmail.com>
This reverts commit 375faed.
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
komalsukhani
approved these changes
Apr 10, 2023
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* WIP - don't override contextRef while updating policy spec Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update test cases Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Add random names to policies Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Fix linter issues Signed-off-by: Burak Sekili <buraksekili@gmail.com> * remove uuid from k8s metadata Signed-off-by: Burak Sekili <buraksekili@gmail.com> * replace fixed name based on the result of previous operation Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update logs command in Makefile. Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update gh workflow for testing Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Add version check to prevent running policy tests in incompatible versions Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Revert "Update gh workflow for testing" This reverts commit 375faed. * Update CHANGELOG.md * Use all uuid in policy spec Signed-off-by: Burak Sekili <buraksekili@gmail.com> * remove duplicated names in policy spec helper Signed-off-by: Burak Sekili <buraksekili@gmail.com> --------- Signed-off-by: Burak Sekili <buraksekili@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tyk Operator overrides
contextReffield in SecurityPolicy spec during reconciliation. This PR fixes this bug and adds test cases to verify deleting either contextRef from SecurityPolicy or SecurityPolicy resource directly works properly.Related Issue
https://tyktech.atlassian.net/browse/TT-8234
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run