Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

fix(ci): Replace hardcoded TLS certificates with auto-generated#589

Merged
buraksekili merged 6 commits intomasterfrom
fix/ci-deprecated-keys
Mar 16, 2023
Merged

fix(ci): Replace hardcoded TLS certificates with auto-generated#589
buraksekili merged 6 commits intomasterfrom
fix/ci-deprecated-keys

Conversation

@buraksekili
Copy link

@buraksekili buraksekili commented Mar 16, 2023

Description

Previously CI was failing due to failures happening on test cases where we try to check if your k8s secret is loaded to Tyk or not. However, we were using hardcoded secrets which might be out of date. Therefore, operator faces API calls error due to deprecated keys.

This PR removes hardcoded keys. Instead, it introduces functions used in Tyk GW repo to generate keys on fly during testing.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@buraksekili buraksekili marked this pull request as ready for review March 16, 2023 11:37
@buraksekili buraksekili requested a review from a team as a code owner March 16, 2023 11:37
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team March 16, 2023 11:37
@buraksekili buraksekili merged commit 13a495a into master Mar 16, 2023
@buraksekili buraksekili deleted the fix/ci-deprecated-keys branch March 16, 2023 12:50
buger pushed a commit that referenced this pull request May 22, 2024
* Replace hardcoded key with on-fly generated ones

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* Fix linter issues

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* Update CHANGELOG

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

---------

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants