This repository was archived by the owner on Oct 11, 2024. It is now read-only.
fix(ci): Replace hardcoded TLS certificates with auto-generated#589
Merged
buraksekili merged 6 commits intomasterfrom Mar 16, 2023
Merged
fix(ci): Replace hardcoded TLS certificates with auto-generated#589buraksekili merged 6 commits intomasterfrom
buraksekili merged 6 commits intomasterfrom
Conversation
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…yk-operator into fix/ci-deprecated-keys
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
andrei-tyk
approved these changes
Mar 16, 2023
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Replace hardcoded key with on-fly generated ones Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Fix linter issues Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update CHANGELOG Signed-off-by: Burak Sekili <buraksekili@gmail.com> --------- Signed-off-by: Burak Sekili <buraksekili@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Previously CI was failing due to failures happening on test cases where we try to check if your k8s secret is loaded to Tyk or not. However, we were using hardcoded secrets which might be out of date. Therefore, operator faces API calls error due to deprecated keys.
This PR removes hardcoded keys. Instead, it introduces functions used in Tyk GW repo to generate keys on fly during testing.
Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run