Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

fix: integration tests scenario to verify ApiDefinition behaviour#580

Merged
buraksekili merged 1 commit intomasterfrom
fix/ci-failures-access-api
Mar 2, 2023
Merged

fix: integration tests scenario to verify ApiDefinition behaviour#580
buraksekili merged 1 commit intomasterfrom
fix/ci-failures-access-api

Conversation

@buraksekili
Copy link

@buraksekili buraksekili commented Mar 2, 2023

Description

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@buraksekili
Remove integration tests that sent a request to Tyk GW in order to
14c1a7f 
verify if ApiDefinition forwards requests properly. Instead of doing
that, send an API call to GW/Dashboard to check if ApiDefinition is
configured properly or not (secret is created etc.,)

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@buraksekili buraksekili marked this pull request as ready for review March 2, 2023 11:47
@buraksekili buraksekili requested a review from a team as a code owner March 2, 2023 11:47
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team March 2, 2023 11:47
@buraksekili buraksekili merged commit a53fef8 into master Mar 2, 2023
@buraksekili buraksekili deleted the fix/ci-failures-access-api branch March 2, 2023 15:10
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili
Remove integration tests that sent a request to Tyk GW in order to (#580
ed43225 
)

verify if ApiDefinition forwards requests properly. Instead of doing
that, send an API call to GW/Dashboard to check if ApiDefinition is
configured properly or not (secret is created etc.,)

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrei-tyk andrei-tyk andrei-tyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buraksekili @andrei-tyk