Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

TT-8232 Allow filtering by category regardless of the flags set#565

Merged
singhpr merged 6 commits intomasterfrom
snapshot-UX-improvement
Mar 14, 2023
Merged

TT-8232 Allow filtering by category regardless of the flags set#565
singhpr merged 6 commits intomasterfrom
snapshot-UX-improvement

Conversation

@zalbiraw
Copy link

@zalbiraw zalbiraw commented Feb 8, 2023 •
edited
Loading

Description

Allow the category flag to apply if the --separate flag is also set.

Related Issue

Motivation and Context

It makes sense to have.

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@zalbiraw zalbiraw requested a review from a team as a code owner February 8, 2023 16:22
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team February 8, 2023 16:22
@zalbiraw zalbiraw changed the title Snapshot UX Improvement WIP: Snapshot UX Improvement Feb 8, 2023
asoorm
asoorm reviewed Feb 9, 2023
View reviewed changes
Copy link

@asoorm asoorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to help you along your way

@zalbiraw zalbiraw changed the title WIP: Snapshot UX Improvement Allow filtering by category regardless of the flags set Feb 9, 2023
@zalbiraw zalbiraw closed this Feb 9, 2023
@zalbiraw zalbiraw force-pushed the snapshot-UX-improvement branch from 3db1898 to 3b53e86 Compare February 9, 2023 16:35
@zalbiraw zalbiraw reopened this Feb 9, 2023
@komalsukhani
Copy link
Contributor

komalsukhani commented Feb 10, 2023

@zalbiraw Can you resolve the lint errors?

@zalbiraw
Copy link
Author

zalbiraw commented Feb 10, 2023

Done!

buraksekili
buraksekili approved these changes Mar 8, 2023
View reviewed changes
Copy link

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zalbiraw

@buraksekili buraksekili changed the title Allow filtering by category regardless of the flags set TT-8232 Allow filtering by category regardless of the flags set Mar 8, 2023
@singhpr singhpr merged commit a13e33c into master Mar 14, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@buraksekili buraksekili mentioned this pull request Mar 23, 2023
Closed
@AlexChesser
Copy link

AlexChesser commented Mar 23, 2023

I was doing some testing over here #591 and it looks like policies do not get filtered by their category should that also be included in the update?

buger pushed a commit that referenced this pull request May 22, 2024
@zalbiraw @buraksekili @singhpr
TT-8232 Allow filtering by category regardless of the flags set (#565)
473fcb5 
* Allow category filtering regardless of what other flags are set

* fix linter issues

---------

Co-authored-by: Burak Sekili <buraksekili@gmail.com>
Co-authored-by: Pranshu <104971506+singhpr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@komalsukhani komalsukhani Awaiting requested review from komalsukhani komalsukhani was automatically assigned from TykTechnologies/operator-squad

2 more reviewers

@asoorm asoorm asoorm left review comments

@buraksekili buraksekili buraksekili approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zalbiraw @komalsukhani @AlexChesser @asoorm @buraksekili @singhpr