Description

This PR adds an additional check in delete method of ApiDefinition to control unexpected responses while deleting non-existent APIs in CE. Although the new version (v4.3) of the Gateway does not have such an issue, deleting non-existent APIs in older versions of GW returns 500 which is not detected as NotFound error in Operator. This unexpected response code causes unexpected reconciliation on Operator.

To solve this issue, we check the existence of ApiDefinition after deleting it if any error occurred.

Related Issue

https://tyktech.atlassian.net/browse/TT-7327

Motivation and Context

Test Coverage For This Change

1- Create an ApiDefinition in K8s

kubectl apply -f ./config/samples/httpbin.yaml

2- Get its ID and delete it from Tyk first.

curl -X DELETE -H "x-tyk-authorization: foo" http://localhost:8080/tyk/apis/${API_ID} -i && curl -H "x-tyk-authorization: foo" -s http://localhost:8080/tyk/reload/group

3- Deleting k8s resource should not create any issue

kubectl delete tykapis httpbin

Changes must be consistent across Tyk v3.2 and v4.3

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
• Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
• Make sure you are updating CHANGELOG.md based on your changes.
• My change requires a change to the documentation.
  • If you've changed APIs, describe what needs to be updated in the documentation.
• I have updated the documentation accordingly.
• If you've changed API models, please update CRDs.
  • make manifests
  • make helm
• I have added tests to cover my changes.
• All new and existing tests passed.
• Check your code additions will not fail linting checks:
  • gofmt -s -w .
  • go vet ./...
  • golangci-lint run