Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

[TT-7500] Fix security policy tests#553

Merged
buraksekili merged 24 commits intomasterfrom
fix_security_policy_tests
Jan 5, 2023
Merged

[TT-7500] Fix security policy tests#553
buraksekili merged 24 commits intomasterfrom
fix_security_policy_tests

Conversation

@komalsukhani
Copy link
Contributor

@komalsukhani komalsukhani commented Dec 30, 2022 •
edited by atlassian bot
Loading

Description

Fix security policy integration tests.

Related Issue

TT-7500

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

komalsukhani and others added 23 commits December 30, 2022 18:47
@komalsukhani
Fix security policy tests
5c90eb9
@komalsukhani
Run against all the k8s version temporarily
bd5cf65
@komalsukhani
Commit out reconcile call
ac28e84
@komalsukhani
Fix security policy test
4cc8169
@buraksekili @komalsukhani
Re-create drifts if API returns 404
74d13d5 
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@komalsukhani
Fix lint error
950d439
@komalsukhani
Increase default timeout
2c89b97
@komalsukhani
Increase timeout to 1 min
efd1f23
@komalsukhani
Keep reconcile call to know why is it failing
a47e130
@komalsukhani
Remove manual reconcile call
6a0e277
@komalsukhani
Comment one of the test to make sure there is no side effects of it
96871ea
@komalsukhani
Define different object for result
ee9eb35
@komalsukhani
Print error
4cfa272
@komalsukhani
Fix broken tests
548b23b
@komalsukhani
Comment manual reconcile call
b269b1b
@komalsukhani
Uncomment test
e9f04d6
@komalsukhani
Ensure API is created before creating policy
5a4ebdd
@komalsukhani
Reset back wait timeout to 30s
8a824af
@komalsukhani
Fix linter error
aa84338
@komalsukhani
Fix update security policy function
c588cc2
@komalsukhani
Remove manual reconcile call
424efbe
@komalsukhani
Update changelog
0bc2451
@komalsukhani
Remove reconcile function call from tests
52c2255
@komalsukhani komalsukhani changed the title Fix security policy tests [TT-7500] Fix security policy tests Jan 5, 2023
@komalsukhani komalsukhani marked this pull request as ready for review January 5, 2023 07:26
@komalsukhani komalsukhani requested a review from a team as a code owner January 5, 2023 07:26
@komalsukhani komalsukhani requested review from andrei-tyk and removed request for a team January 5, 2023 07:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@komalsukhani komalsukhani requested review from buraksekili and removed request for andrei-tyk January 5, 2023 07:28
buraksekili
buraksekili approved these changes Jan 5, 2023
View reviewed changes
Copy link

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @komalsukhani

@buraksekili buraksekili merged commit d8a4543 into master Jan 5, 2023
buger pushed a commit that referenced this pull request May 22, 2024
@komalsukhani @buraksekili
[TT-7500] Fix security policy tests (#553)
9952fdd 
* Fix security policy tests

* Run against all the k8s version temporarily

* Commit out reconcile call

* Fix security policy test

* Re-create drifts if API returns 404

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* Fix lint error

* Increase default timeout

* Increase timeout to 1 min

* Keep reconcile call to know why is it failing

* Remove manual reconcile call

* Comment one of the test to make sure there is no side effects of it

* Define different object for result

* Print error

* Fix broken tests

* Comment manual reconcile call

* Uncomment  test

* Ensure API is created before creating policy

* Reset back wait timeout to 30s

* Fix linter error

* Fix update security policy function

* Remove manual reconcile call

* Update changelog

* Remove reconcile function call from tests

* Set back value of k8s version matrix

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Co-authored-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@buraksekili buraksekili buraksekili approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@komalsukhani @buraksekili