Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

[TT-7498] - Add nodeSelector support#552

Merged
singhpr merged 6 commits intomasterfrom
551-can-we-add-nodeselector-support
Jan 5, 2023
Merged

[TT-7498] - Add nodeSelector support#552
singhpr merged 6 commits intomasterfrom
551-can-we-add-nodeselector-support

Conversation

@zalbiraw
Copy link

@zalbiraw zalbiraw commented Dec 29, 2022 •
edited
Loading

Description

Add ability to select which node the operator manger pod is spun up on.

Related Issue

#551

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@zalbiraw zalbiraw requested a review from a team as a code owner December 29, 2022 21:18
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team December 29, 2022 21:18
@zalbiraw zalbiraw linked an issue Dec 29, 2022 that may be closed by this pull request
Add nodeSelector support #551
Closed
buraksekili
buraksekili reviewed Dec 30, 2022
View reviewed changes
Copy link

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @zalbiraw. However, your changes will be overwritten by the subsequent make helm command. Can you please check this comment here? This comment shows the required steps to update helm manifests of tyk operator. Please let me know if you need help

@zalbiraw
Copy link
Author

zalbiraw commented Jan 3, 2023

Thank you @buraksekili. I think its good now?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@buraksekili buraksekili changed the title Add nodeSelector support [TT-7498] - Add nodeSelector support Jan 4, 2023
@singhpr singhpr merged commit e845fbc into master Jan 5, 2023
@buraksekili buraksekili mentioned this pull request Jan 19, 2023
Closed
buger pushed a commit that referenced this pull request May 22, 2024
@zalbiraw
[TT-7498] - Add nodeSelector support (#552)
724bfc8 
* Add nodeSelector support

* Add nodeselector support through kustomize

* remove added vendor file

* revert crd changes

* reset crd file

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@komalsukhani komalsukhani Awaiting requested review from komalsukhani komalsukhani was automatically assigned from TykTechnologies/operator-squad

1 more reviewer

@buraksekili buraksekili buraksekili approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add nodeSelector support

3 participants

@zalbiraw @buraksekili @singhpr