Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Update run_tests.yaml#546

Merged
komalsukhani merged 1 commit intomasterfrom
add-more-version-to-tests
Jan 17, 2023
Merged

Update run_tests.yaml#546
komalsukhani merged 1 commit intomasterfrom
add-more-version-to-tests

Conversation

@zalbiraw
Copy link

@zalbiraw zalbiraw commented Dec 14, 2022

Description

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@zalbiraw zalbiraw requested a review from a team as a code owner December 14, 2022 16:54
@zalbiraw zalbiraw requested review from andrei-tyk and removed request for a team December 14, 2022 16:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@komalsukhani
Copy link
Contributor

komalsukhani commented Dec 15, 2022

@zalbiraw We run tests against more k8s version every nightly.
Do you think it will be better to test against different tyk versions nightly too and on PR run against just 4.3 and 3.2 maybe?

@zalbiraw
Copy link
Author

zalbiraw commented Dec 15, 2022

Hi @komalsukhani this was brought up by @asoorm and @caroltyk. The idea is that we should be testing against at least the major tyk versions in case of breaking changes. Those major branches get updated with every minor release. Example:

4.0 -> 4.0.10
4.3 -> 4.3.1
etc

Since nightly does not encompass all the changes and will never detect merging issues that may happen with already existing branches. Its an added layer of defence.

@komalsukhani
Copy link
Contributor

komalsukhani commented Jan 13, 2023

Hi @zalbiraw, We have agreed to run test against 3.2, 4.3, 4.0 tyk versions. Can you update the PR accordingly?

zalbiraw
zalbiraw commented Jan 13, 2023
View reviewed changes
@zalbiraw
Copy link
Author

zalbiraw commented Jan 13, 2023

Done!

@zalbiraw zalbiraw force-pushed the add-more-version-to-tests branch from c071b87 to b7815ed Compare January 16, 2023 14:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@komalsukhani komalsukhani merged commit 5a54f30 into master Jan 17, 2023
@komalsukhani
Copy link
Contributor

komalsukhani commented Jan 17, 2023

Thank you @zalbiraw

@zalbiraw
Copy link
Author

zalbiraw commented Jan 17, 2023

Anytime!

buger pushed a commit that referenced this pull request May 22, 2024
@zalbiraw
Update .github/workflows/run_tests.yaml (#546)
b32966d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk was automatically assigned from TykTechnologies/operator-squad

1 more reviewer

@komalsukhani komalsukhani komalsukhani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zalbiraw @komalsukhani