line-intersect additional type cleanup#2273
Merged
rowanwins merged 2 commits intoline-intersect-updatefrom Mar 20, 2022
Merged
Conversation
rowanwins
approved these changes
Mar 20, 2022
mfedderly
added a commit
that referenced
this pull request
Apr 2, 2022
* Rewrite line-intersect module * fix jsdoc * update use of sweepline-intersections to not detect self-intersections * inline sweepline-intersections as es5 * Add some ts config * remove unused import * add allowJs * adjust tsconfig * address some eslint issues * Some minor typing updates to get the build to pass * Fix imports after merge * rejig ts config * update yarn lock * add extra option to line-intersect re self-intersections * run prettier * update the turf-line-split outputs * fix prettier * line-intersect additional type cleanup (#2273) * some cleanup * clarify Intersection type * line-intersect-typescript-cleanup (#2274) * bump sweepline-intersections to 1.4.0 Co-authored-by: Matt Fedderly <mfedderly@palantir.com> Co-authored-by: Tim Welch <tim.j.welch@gmail.com> Co-authored-by: mfedderly <mdfedderly@mdfedderly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rowanwins Please consider this bit of type cleanup for #2033, removing use of any. Plus one more bit of cleanup while I was there. Seemed easier than trying to comment on it.
I tried to add a default function signature for findIntersections to the empty sweepline-intersections module declaration file you created, but could not get VSCode to pick up the types. Failing that, I at least improved from use of any to a more explicit cast for result of findIntersections()