This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Fix image loading issues due to http urls #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
On second thought, maybe it's worth to force https for other media links from knwon sources, like imgur and others. And if domian isn't in the whitelist for https rewrite, show it as ordinary link. |
Collaborator
Author
I see that media providers with their own create* methods already produce https only links so this lefts us with redditupload and redd.it only. |
msfjarvis
added a commit
to msfjarvis/Dawn
that referenced
this pull request
Aug 5, 2020
…jarvis/swipe-gesture-icon-position' into features * msfjarvis/multiple_accounts: (24 commits) Adds multiple accounts support Prepare next version Update changelog for 0.9.1 (Tunous#198) Force logout all users (Tunous#196) Handle exceptions while opening a browser (Tunous#108) (Tunous#193) Prevent selection of negative ranges in SelectionLimitingTextView (fixes Tunous#190) (Tunous#194) Prepare next version Release 0.9.0 (Tunous#184) Release workflow (Tunous#185) Fix image loading issues due to http urls (Tunous#183) Selftext selection (Tunous#178) Submission title selection (Tunous#182) Update changelog with missed changes Wrap comment byline when it is too long to fit in one line (Tunous#145) Revert "Run Debug workflow only on push" Upgrade to Gradle 6.3 and add checksum field for F-Droid (Tunous#180) Run Debug workflow only on push Upgrade Gradle to 6.2.1 (Tunous#152) Use GitHub Actions (#72) Switch to on-device link unfurler (Tunous#138) ... * msfjarvis/swipe-gesture-icon-position: (26 commits) Return false to keep the touch flow going Make the gestures' icons follow touch event position on Y Swipe Actions' icons at same level as touch event Prepare next version Update changelog for 0.9.1 (Tunous#198) Force logout all users (Tunous#196) Handle exceptions while opening a browser (Tunous#108) (Tunous#193) Prevent selection of negative ranges in SelectionLimitingTextView (fixes Tunous#190) (Tunous#194) Prepare next version Release 0.9.0 (Tunous#184) Release workflow (Tunous#185) Fix image loading issues due to http urls (Tunous#183) Selftext selection (Tunous#178) Submission title selection (Tunous#182) Update changelog with missed changes Wrap comment byline when it is too long to fit in one line (Tunous#145) Revert "Run Debug workflow only on push" Upgrade to Gradle 6.3 and add checksum field for F-Droid (Tunous#180) Run Debug workflow only on push Upgrade Gradle to 6.2.1 (Tunous#152) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I stumbled across this:
- http redd.it link in the wild. This happens since Android >=9 forces https-only network security policy. Here's the fix