Dropping the database invalidates cookies#504
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Aug 24, 2013
javorszky:iss418
Merged
Dropping the database invalidates cookies#504ErisDS merged 1 commit intoTryGhost:masterfrom javorszky:iss418
ErisDS merged 1 commit intoTryGhost:masterfrom
javorszky:iss418
Conversation
Closes #418. * Moved the app config behind the promise wall (I couldn't reliably assign generated uuid to the ghost object AND have access to an automatically created db from fixtures AND not have circular reference (try including api in ghost.js ;) )) * Added new functionality to `ghost.init()`, which is responsible for the first run bit (I'm thinking plopping a filter or an action in there for future devs) * Modified `.gitignore` so the `.png`s casper generates aren't added * Fixed ambiguity and typos here and there, see code
Member
|
Had a look over this, looks good 👍 want to give it a bit of a test before merging tho. Hang tight :) |
ErisDS
added a commit
that referenced
this pull request
Aug 24, 2013
Dropping the database invalidates cookies
This was referenced Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418.
ghost.init(), which is responsible for the first run bit (I'm thinking plopping a filter or an action in there for future devs).gitignoreso the.pngs casper generates aren't added