Skip to content

Implements new Configuration API#3841

Merged
sebgie merged 1 commit intoTryGhost:masterfrom
halfdan:3619-configuration-api
Sep 1, 2014
Merged

Implements new Configuration API#3841
sebgie merged 1 commit intoTryGhost:masterfrom
halfdan:3619-configuration-api

Conversation

@halfdan
Copy link
Contributor

@halfdan halfdan commented Aug 20, 2014

closes #3619

  • adds new permissions for configuration API
  • adds integration tests
  • adds configuration API for reading allowed values

@novaugust
Copy link
Contributor

So this returns something like

/configuration

{
  "configuration" : [
  {  
      "key": "version",
      "value": "0.5.0"
  },
  {
     "key": "apps",
     "value": false
  },
 ....
  ]
}

/configuration/version

{
  "configuration" : [
  {  
      "key": "version",
      "value": "0.5.0"
  }
}

Si?

@halfdan
Copy link
Contributor Author

halfdan commented Aug 21, 2014

Sí señor!
On 21 Aug 2014 04:28, "Matt Enlow" notifications@github.com wrote:

So this returns something like

/configuration

{
"configuration" : [
{
"key": "version",
"value": "0.5.0"
},
{
"key": "apps",
"value": false
},
....
]}

/version

{
"configuration" : [
{
"key": "version",
"value": "0.5.0"
}}

Si?


Reply to this email directly or view it on GitHub
#3841 (comment).

@ErisDS
Copy link
Member

ErisDS commented Aug 25, 2014

@halfdan this is blocking the About Ghost page, can you please give us an update? Are you able to finish this or would you like to drop it?

@halfdan
Copy link
Contributor Author

halfdan commented Aug 26, 2014

@ErisDS Ah goddamnit. I don't know what the Internet in turkey was showing me - I thought this was long merged. Will update according to feedback.

@halfdan halfdan force-pushed the 3619-configuration-api branch 3 times, most recently from 49032f3 to 935556a Compare August 31, 2014 13:55
closes TryGhost#3619
- adds new permissions for configuration API
- adds integration tests
- adds configuration API for reading allowed values
@halfdan halfdan force-pushed the 3619-configuration-api branch from 935556a to 688b391 Compare August 31, 2014 20:54
sebgie added a commit that referenced this pull request Sep 1, 2014
@sebgie sebgie merged commit 57b5f4d into TryGhost:master Sep 1, 2014
@halfdan halfdan deleted the 3619-configuration-api branch September 1, 2014 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API endpoint for configuration

4 participants