ghost/core/core/server/services/member-attribution/attribution-builder.js (1)

1-15: Consider updating the AttributionResource typedef.

The postStatus field is now returned by getResource() for post types, but it's not documented in the AttributionResource typedef. Adding it would improve documentation completeness and IDE support.

📝 Proposed typedef update

 /**
  * `@typedef` {object} AttributionResource
  * `@prop` {string|null} id
  * `@prop` {string|null} url (absolute URL)
  * `@prop` {'page'|'post'|'author'|'tag'|'url'|null} type
  * `@prop` {string|null} title
+ * `@prop` {string|undefined} postStatus
  * `@prop` {string|null} referrerSource
  * `@prop` {string|null} referrerMedium
  * `@prop` {string|null} referrerUrl

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/member-attribution/attribution-builder.js`
around lines 1 - 15, The AttributionResource typedef is missing the postStatus
property returned by getResource() for post types; update the typedef for
AttributionResource to include a postStatus field (string or a union of expected
statuses for posts, e.g., 'draft'|'published'|'scheduled'|null) so IDEs and docs
reflect the data returned by getResource() and to reference this new property in
any code handling post resources.

ghost/core/test/e2e-server/services/member-attribution.test.js (1)

95-103: Guard fixture cleanup with try/finally.

If an assertion fails after Line 95, the restore at Line 103 is skipped and leaves shared fixture state mutated for later tests.

Suggested cleanup hardening

-                await models.Post.edit({status: 'draft'}, {id});
-
-                assertObjectMatches(await attribution.fetchResource(), {
-                    id: post.id,
-                    type: 'post',
-                    title: post.get('title')
-                });
-
-                await models.Post.edit({status: 'published'}, {id});
+                await models.Post.edit({status: 'draft'}, {id});
+                try {
+                    assertObjectMatches(await attribution.fetchResource(), {
+                        id: post.id,
+                        type: 'post',
+                        title: post.get('title')
+                    });
+                } finally {
+                    await models.Post.edit({status: 'published'}, {id});
+                }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/test/e2e-server/services/member-attribution.test.js` around lines
95 - 103, Wrap the temporary status change and assertion in a try/finally so the
post is always restored: call models.Post.edit({status: 'draft'}, {id}) before
the try, perform the assertion using attribution.fetchResource() inside the try,
and in the finally call models.Post.edit({status: 'published'}, {id}) to
guarantee cleanup even if the assertion fails; reference the existing post/id
variables and the attribution.fetchResource() call when making this change.