Update package.json for publishing to npm#2239
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Feb 24, 2014
Merged
Conversation
Member
|
2 commands instead of 1? That's 100% more work for me! 😱 I was thinking about this t'other day actually. I think the |
Contributor
Author
|
Aha, nice improvement. Definitely can-do. Will update with that change. |
Contributor
Author
|
Updated! =D. That was a fun trick :D |
Member
|
Neat 👍 |
address TryGhost#2078 - removes private: true flag from package.json - created .npmignore file and moved all of buildGlob file patterns into here, negating all patterns as the npmignore file defines what is to be excluded and not included. - gruntfile now uses the inverse of the .npmignore file to define what files to include in a release
ErisDS
added a commit
that referenced
this pull request
Feb 24, 2014
Update package.json for publishing to npm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #2078
from being included in the npm package
So as I currently understand it,
npm publishwill take all contents in the folder (excluding those specified in the.npmignorefile) and pack that to be included in the npm package.This means that it'll include the compiled assets by default, addressing item 1 in #2078. However before publishing we need to ensure
grunt prodis run so the assets are up to date.I previously tried doing that with the
prepublishscript (docs here) however that is also ran onnpm install, something we cannot do.The publish process looks like this:
Which we could turn into a grunt task however that seems necessary.
That part is up to you @ErisDS, as you'll be the one doing the publishing ;).