Support for urlSSL config option and forceAdminSSL 403 response#2238
Support for urlSSL config option and forceAdminSSL 403 response#2238ErisDS merged 1 commit intoTryGhost:masterfrom
Conversation
|
I'm very sorry for taking so long to come back to your PR. I have tested the functionality and it is working as expected 👍. Due to the change from jslint to jshint the tests are failing and the PR would need rebasing (only a minor conflict). If you have a moment could you eventually update the PR or leave a comment if you have no time to do the changes? Thank you! |
|
Yeah ok I can update it. Might be tight this week though, and then away for another week. If I don't do it this week, I'll do it when I come back. Will need to re-check what has changed in the codebase since then with regards to |
|
@gimelfarb excellent, just drop us a comment let us know when you're done. 0.5 doesn't close for some time yet but if at any point it becomes clear you don't have time, just drop us a comment to let us know that instead 👍 |
closes TryGhost#1838 - adding `forceAdminSSL: {redirect: true/false}` option to allow 403 over non-SSL rather than redirect - adding `urlSSL` option to specify SSL variant of `url` - using `urlSSL` when redirecting to SSL (forceAdminSSL), if specified - dynamically patching `.url` property for view engine templates to use SSL variant over HTTPS connections (pass `.secure` property as view engine data) - using `urlSSL` in a "reset password" email, if specified - adding unit tests to test `forceAdminSSL` and `urlSSL` options - created a unit test utility function to dynamically fork a new instance of Ghost during the test, with different configuration options
|
Ok finally got around to doing this. Rebased the commit, fixed merging issues, and made sure the tests pass and build is all "green". All yours to merge! :) |
Support for urlSSL config option and forceAdminSSL 403 response
closes #1838
forceAdminSSL: {redirect: true/false}option to allow 403 over non-SSL rather than redirecturlSSLoption to specify SSL variant ofurlurlSSLwhen redirecting to SSL (forceAdminSSL), if specified.urlproperty for view engine templates to use SSL variant over HTTPS connections (pass.secureproperty as view engine data)urlSSLin a "reset password" email, if specifiedforceAdminSSLandurlSSLoptions