Skip to content

Fix package.json scripts to be more in line with#2218

Merged
ErisDS merged 1 commit intoTryGhost:masterfrom
hswolff:npm-package-updates
Feb 19, 2014
Merged

Fix package.json scripts to be more in line with#2218
ErisDS merged 1 commit intoTryGhost:masterfrom
hswolff:npm-package-updates

Conversation

@hswolff
Copy link
Contributor

@hswolff hswolff commented Feb 19, 2014

expected behavior of npm packages

fixes #1053

  • updates travis config to be more in line with
    current dev steps
  • fix grunt-cli warning from appearing when
    running grunt

I tried adding the prepublish script to package.json however it seems that script is run at two points:

From npm-scripts:

prepublish: Run BEFORE the package is published. (Also run on local npm install without any arguments.)

So when you go to npm install anything in prepublish is ran as well unfortunately.

This is proving much more squirrelly than first blush :).

expected behavior of npm packages

fixes TryGhost#1053

- updates travis config to be more in line with
 current dev steps

- fix `grunt-cli` warning from appearing when
 running grunt
ErisDS added a commit that referenced this pull request Feb 19, 2014
Fix package.json scripts to be more in line with
@ErisDS ErisDS merged commit fe34ced into TryGhost:master Feb 19, 2014
This was referenced Feb 19, 2014
@hswolff hswolff deleted the npm-package-updates branch February 19, 2014 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm test currently doesn't work without globally installing grunt-cli

2 participants