Fix package.json scripts to be more in line with#2218
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Feb 19, 2014
Merged
Conversation
expected behavior of npm packages fixes TryGhost#1053 - updates travis config to be more in line with current dev steps - fix `grunt-cli` warning from appearing when running grunt
ErisDS
added a commit
that referenced
this pull request
Feb 19, 2014
Fix package.json scripts to be more in line with
This was referenced Feb 19, 2014
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expected behavior of npm packages
fixes #1053
current dev steps
grunt-cliwarning from appearing whenrunning grunt
I tried adding the
prepublishscript topackage.jsonhowever it seems that script is run at two points:From npm-scripts:
So when you go to
npm installanything inprepublishis ran as well unfortunately.This is proving much more squirrelly than first blush :).