Merged
Conversation
Contributor
|
👍 Nice work! |
Contributor
|
This is super @hswolff !! |
Member
|
Apart from that one little buggle this all looks 👍 🍰 |
fixes TryGhost#2111 - modified Post model to support a tag query param that will filter the desired post collection to only include posts that contain the requested tag - in the updated Post model it includes the Tag model under a nested object called 'aspects' - added tests for updated Post model, updating test utils to add more posts_tags relations - adds two new routes to frontend, one for initial tag page, another to page that tag page - for tag pages the array of posts is exposed to the view similarly to the homepeage - on the tag view page the information for the tag is also accessible for further theme usage - the tag view page supports a hierarchy of views, it'll first attempt to use a tag.hbs file if it exists, otherwise fall back to the default index.hbs file - modified pageUrl and pagination helper to have it be compatible with tag paging - added unit tests for frontend controller - added unit tests for handlebar helper modifications - add functional tests for new tag routes
Contributor
Author
|
Thanks for the review! Great catch! :D Pushed fix for that. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2111
param that will filter the desired post collection
to only include posts that contain the requested tag
under a nested object called 'aspects'
test utils to add more posts_tags relations
one for initial tag page,
another to page that tag page
is exposed to the view similarly
to the homepeage
for the tag is also accessible
for further theme usage
views, it'll first attempt to use a tag.hbs
file if it exists, otherwise fall back
to the default index.hbs file
to have it be compatible with tag paging