Skip to content

Conversation

@mario-van-zadel
Copy link

  • Bump json-schema to version 0.2.5
  • Set version constraints to allow future patch updates (semantic versioning)

@mario-van-zadel
Copy link
Author

@ferranvila thank you for reviewing the pull request! There still appears the message "Review required" at the bottom of this PR. Do we have to explicitly mark this PR as "reviewed" to be able to merge it?

Comment on lines +11 to +14
"assert-plus": "^1.0.0",
"extsprintf": "^1.3.0",
"json-schema": "^0.2.5",
"verror": "^1.10.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is important for downstream users and I hope the maintainers can review and merge. But perhaps the versions should remain pinned rather than allowing ranges?

Suggested change
"assert-plus": "^1.0.0",
"extsprintf": "^1.3.0",
"json-schema": "^0.2.5",
"verror": "^1.10.0"
"assert-plus": "1.0.0",
"extsprintf": "1.3.0",
"json-schema": "0.2.5",
"verror": "1.10.0"

@dev-trilobyte
Copy link

There is CVE-2021-3918 by now - json-schema should be updated to newly published version 0.4.0.
All versions up to 0.3.0 are vulnerable and already flagged by security scanners...

@JJ
Copy link

JJ commented Nov 15, 2021

There is CVE-2021-3918 by now - json-schema should be updated to newly published version 0.4.0. All versions up to 0.3.0 are vulnerable and already flagged by security scanners...

Created #32 to take that into account, incorporating also this PR.

@bahamat
Copy link
Contributor

bahamat commented Nov 17, 2021

Fixed in 017f744

@bahamat bahamat closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants