Upgrading upstream dep to avoid vulnerability #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceHaley
approved these changes
Nov 16, 2021
This was referenced Nov 16, 2021
jschirrmacher
approved these changes
Nov 16, 2021
Author
|
@bahamat any feedback on this? |
Morl99
reviewed
Nov 16, 2021
Comment on lines
+11
to
+14
| "assert-plus": "^1.0.0", | ||
| "extsprintf": "^1.3.0", | ||
| "json-schema": "^0.4.0", | ||
| "verror": "^1.10.0" |
There was a problem hiding this comment.
Why are you adding carets? If you think this is a good idea, you should separate this into a different PR, otherwise you risk that this PR will get lost in discussion due to that unexpected change. Or was that merely by mistake?
This was referenced Nov 16, 2021
Contributor
|
Fixed in 017f744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype polution: https://security.snyk.io/vuln/SNYK-JS-JSONSCHEMA-1920922
Incorporates #27 since it's got a better representation for the remaining deps.