Fix bitmask for reading year register in getDateTime()#8
Merged
rafacouto merged 1 commit intoTreboada:masterfrom Dec 29, 2023
Merged
Conversation
Collaborator
|
You're right, according to datasheet the register at 0x8D is a 8-bit mask:
Thank you for the PR! 👍 |
rafacouto
referenced
this pull request
in danielc123/Ds1302
Jan 4, 2024
…e register is unwanted written
danielc123
added a commit
to danielc123/Ds1302
that referenced
this pull request
Jan 21, 2024
…Rafa Couto, reference Treboada#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, and thanks for the awesome library!
I found a mistake in the bitmask used to read the year register in Ds1302::getDateTime(), which causes wrong readings when the year is greater than 80. This PR fixes it - I've already tested the change.
Cheers!