Skip to content

refactor(action-panel): normalize expression handling in action form schema#2256

Merged
daryllimyt merged 1 commit intomainfrom
codex/run-if-delete-save-fix
Mar 4, 2026
Merged

refactor(action-panel): normalize expression handling in action form schema#2256
daryllimyt merged 1 commit intomainfrom
codex/run-if-delete-save-fix

Conversation

@daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Mar 4, 2026

Checklist

  • Read CONTRIBUTING.md.
  • PR title is short and non-generic (see previously merged PRs for examples).
  • PR only implements a single feature or fixes a single bug.
  • Tests passing (uv run pytest tests)?
  • Lint / pre-commits passing (pre-commit run --all-files)?

Description

Related Issues

Screenshots / Recordings

Steps to QA


Summary by cubic

Normalized expression handling in the Action Panel form to trim values, treat whitespace-only and ${{ }} as empty, and persist run_if as null when unset. Prevents saving invalid control-flow fields and keeps payloads consistent.

  • Refactors
    • Added EMPTY_TEMPLATE_EXPRESSION_RE and normalizeOptionalExpression to return undefined for empty or ${{ }} expressions.
    • Applied normalization to for_each (arrays/strings), run_if, retry_until, wait_until, and environment; for arrays, map and drop undefined items.

Written for commit a0b9843. Summary will update on new commits.

Copy link
Contributor Author

daryllimyt commented Mar 4, 2026

@daryllimyt daryllimyt marked this pull request as ready for review March 4, 2026 21:07
@daryllimyt daryllimyt requested a review from jordan-umusu March 4, 2026 21:08
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@daryllimyt daryllimyt force-pushed the codex/run-if-delete-save-fix branch from ef2bfc0 to 66896db Compare March 4, 2026 21:11
@daryllimyt daryllimyt force-pushed the codex/run-if-stack-2-tag-directory-items-invalidate branch from 633bcbc to 51c315b Compare March 4, 2026 21:12
@daryllimyt daryllimyt force-pushed the codex/run-if-delete-save-fix branch from 66896db to 923d71d Compare March 4, 2026 21:21
Copy link
Contributor Author

daryllimyt commented Mar 4, 2026

Merge activity

  • Mar 4, 9:32 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 4, 9:35 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 4, 9:35 PM UTC: @daryllimyt merged this pull request with Graphite.

@daryllimyt daryllimyt changed the base branch from codex/run-if-stack-2-tag-directory-items-invalidate to graphite-base/2256 March 4, 2026 21:32
@daryllimyt daryllimyt changed the base branch from graphite-base/2256 to main March 4, 2026 21:33
@daryllimyt daryllimyt force-pushed the codex/run-if-delete-save-fix branch from 923d71d to a0b9843 Compare March 4, 2026 21:34
@daryllimyt daryllimyt merged commit 6e8e689 into main Mar 4, 2026
11 checks passed
@daryllimyt daryllimyt deleted the codex/run-if-delete-save-fix branch March 4, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants