Skip to content

feat(ui): Tables nits#2199

Merged
topher-lo merged 2 commits intomainfrom
fix/ui-tables-nits
Feb 26, 2026
Merged

feat(ui): Tables nits#2199
topher-lo merged 2 commits intomainfrom
fix/ui-tables-nits

Conversation

@topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Feb 26, 2026

Summary

  • drop the redundant header from the workspace members page and rely on the sidebar navigation
  • add a sidebar footer slot powered by SidebarFooter and push the Members item into the settings items for the footer user nav
  • extend SidebarUserNav to accept configurable settings links that appear under the Settings menu and show the Members link when the user can view members

Testing

  • Not run (not requested)

Summary by cubic

Moved the Members link into the sidebar footer Settings menu, removed the Workspace Members header, and standardized page padding for consistency. Also improved the role change dialog and reduced unnecessary data fetching.

  • Refactors

    • Added SidebarFooter and moved SidebarUserNav to the footer; shows Members under Settings when permitted.
    • Standardized layout/padding with container spacing on Members and Tables pages.
    • Tuned hooks with 5-minute caching and disabled window refetch; added conditional enable flags to avoid fetching until dialogs are open.
  • Bug Fixes

    • Hardened role change flow: validation for missing user/role, disabled controls during loading/mutations, and load roles/assignments only when the dialog is open.

Written for commit 42206d5. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@topher-lo topher-lo changed the title Move members link into sidebar footer settings menu feat(ui): Tables nits Feb 26, 2026
@topher-lo topher-lo added the ui Improvements or additions to UI/UX label Feb 26, 2026
@topher-lo topher-lo merged commit 2f6f0dd into main Feb 26, 2026
13 checks passed
@topher-lo topher-lo deleted the fix/ui-tables-nits branch February 26, 2026 16:50
daryllimyt pushed a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Improvements or additions to UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant